Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines for making new capability proposals #207

Merged

Conversation

tigrannajaryan
Copy link
Member

As discussed with OpAMP approvers/maintainers this adds the requirement to have working prototypes for specification proposals.

As discussed with OpAMP approvers/maintainers this
adds the requirement to have working prototypes for
specification proposals.
Copy link

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, most just wording suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@andykellr andykellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, but otherwise LGTM. Thank you for writing this up.

Co-authored-by: Andy Keller <andykellr@users.noreply.github.com>
@tigrannajaryan tigrannajaryan merged commit 27c3a65 into open-telemetry:main Nov 27, 2024
5 checks passed
@tigrannajaryan tigrannajaryan deleted the tigran/contributing branch November 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants